Open
Conversation
|
Yes, please! Thank you! |
Contributor
|
Useful addition! New UI for Dash/Eros is coming for 4.0. Check out compose or omnipod branch. This PR will likely have conflicts. Compose branch will be merged to dev "soon". |
mcnelson
force-pushed
the
omnipod_hard_end
branch
from
6711d52 to
ecadcc5
Compare
|
Contributor
Author
|
@olorinmaia Thanks for heads up. PR updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes adding the end of the Omnipod grace period called the hard-end date in the Omnipod Eros and Dash tabs. It's the expiry date + 8 hours. I'm sure we all use some of the grace period in one way or another. :)
I have tested the first commit (adding the date) for a couple of months in production on both Eros and Dash. Currently testing the color treatment. I forgot to add it initially. Edit: Seeing the color treatment working correctly so far.